| From: | "Daniel Verite" <daniel(at)manitou-mail(dot)org> |
|---|---|
| To: | "Artur Zakirov" <zaartur(at)gmail(dot)com> |
| Cc: | Sutou Kouhei <kou(at)clear-code(dot)com>, tgl(at)sss(dot)pgh(dot)pa(dot)us, bruce(at)momjian(dot)us, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fixing backslash dot for COPY FROM...CSV |
| Date: | 2024-09-30 19:15:44 |
| Message-ID: | 4db6ba9b-57e8-403a-893e-b91c979cff69@manitou-mail.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Artur Zakirov wrote:
> I've tested the patch and it seems it works as expected.
Thanks for looking at this!
> It seems it isn't necessary to handle "\." within
> "CopyAttributeOutCSV()" (file "src/backend/commands/copyto.c")
> anymore.
It's still useful to produce CSV data that can be safely
reloaded by previous versions.
Until these versions are EOL'ed, I assume we'd better
continue to quote "\."
> Another thing is that the comparison "copystream ==
> pset.cur_cmd_source" happens twice within "handleCopyIn()". TBH it is
> a bit confusing to me what is the real purpose of that check, but one
> of the comparisons looks unnecessary.
Indeed, good catch. The redundant comparison is removed in the
attached v6.
Best regards,
--
Daniel Vérité
https://postgresql.verite.pro/
Twitter: @DanielVerite
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Support-backslash-dot-on-a-line-by-itself-as-vali.patch | text/plain | 8.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-09-30 19:24:26 | Re: SET or STRICT modifiers on function affect planner row estimates |
| Previous Message | Tom Lane | 2024-09-30 19:09:51 | Re: pg_basebackup and error messages dependent on the order of the arguments |