From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_basebackup and error messages dependent on the order of the arguments |
Date: | 2024-09-30 19:09:51 |
Message-ID: | 1494959.1727723391@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
"Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com> writes:
>> Taking a closer look, many of the other switches-requiring-an-argument
>> also just absorb "optarg" without checking its value till much later,
>> so I'm not sure how far we could move the needle by special-casing
>> --compress.
> My point was not so much about --compress but rather giving a good error message.
Right, and my point was that the issue is bigger than --compress.
For example, you get exactly the same misbehavior with
$ pg_basebackup --checkpoint=fast --format=t -d --pgdata=/var/tmp/dummy
pg_basebackup: error: must specify output directory or backup target
pg_basebackup: hint: Try "pg_basebackup --help" for more information.
I'm not sure how to solve the problem once you consider this larger
scope. I don't think we could forbid arguments beginning with "-" for
all of these switches.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Verite | 2024-09-30 19:15:44 | Re: Fixing backslash dot for COPY FROM...CSV |
Previous Message | Noah Misch | 2024-09-30 18:49:41 | Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation |