Re: psql: fix variable existence tab completion

From: "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Erik Wienhold <ewie(at)ewie(dot)name>, Steve Chavez <steve(at)supabase(dot)io>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql: fix variable existence tab completion
Date: 2024-07-20 23:24:25
Message-ID: 4d6450cf-2cc4-40e9-a810-ce9bae78e122@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19.07.2024 01:10, Tom Lane wrote:
> Actually, I think we ought to just reject this change. Debian 10
> will be two years past EOL before PG 17 ships. So I don't see a
> reason to support it in the tests anymore. One of the points of
> such testing is to expose broken platforms, not mask them.
>
> Obviously, if anyone can point to a still-in-support platform
> with the same bug, that calculus might change.

The bug when broken version of libedit want to backslash some symbols
(e.g. double quotas, curly braces, the question mark)
i only encountered on Debian 10 (buster).

If anyone has encountered a similar error on some other system,
please share such information.

> With respect to the other hacks Alexander mentions, maybe we
> could clean some of those out too? I don't recall what platform
> we had in mind there, but we've moved our goalposts on what
> we support pretty far in the last couple years.

Agreed that no reason to save workarounds for non-supported systems.
Here is the patch that removes fixes for Buster bug mentioned above.

With the best regards,

--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
v1-0001-Remove-workarounds-for-Debian-10.patch text/x-patch 2.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2024-07-20 23:32:46 Re: Report search_path value back to the client.
Previous Message Tomas Vondra 2024-07-20 23:06:55 Re: Parallelize correlated subqueries that execute within each worker