Re: psql: fix variable existence tab completion

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru>
Cc: Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Erik Wienhold <ewie(at)ewie(dot)name>, Steve Chavez <steve(at)supabase(dot)io>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql: fix variable existence tab completion
Date: 2024-07-18 22:10:29
Message-ID: 4001917.1721340629@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Anton A. Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru> writes:
> On 06.05.2024 13:19, Alexander Korotkov wrote:
>> Now there is a similar workaround in the 010_tab_completion.pl with regex: qr/"mixedName\\?" /

> I think if there were or will be complaints from users about this behavior in Debian 10,
> then it makes sense to look for more complex solutions that will fix a backslash substitutions.
> If no such complaints, then it is better to make a workaround in test.

Actually, I think we ought to just reject this change. Debian 10
will be two years past EOL before PG 17 ships. So I don't see a
reason to support it in the tests anymore. One of the points of
such testing is to expose broken platforms, not mask them.

Obviously, if anyone can point to a still-in-support platform
with the same bug, that calculus might change.

With respect to the other hacks Alexander mentions, maybe we
could clean some of those out too? I don't recall what platform
we had in mind there, but we've moved our goalposts on what
we support pretty far in the last couple years.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2024-07-18 22:17:44 Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx
Previous Message Tomas Vondra 2024-07-18 21:49:16 Re: change regexp_substr first argument make tests more easier to understand.