From: | Joshua Tolley <eggyknap(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Out of date comment in xlogutils.c |
Date: | 2010-07-08 16:01:22 |
Message-ID: | 4c35f654.5429e70a.4f74.0e8c@mx.google.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I noticed the following out-of-date bits in a comment in xlogutils.c:
* LockBuffer(buffer, BUFFER_LOCK_EXCLUSIVE), for reading from the main
* fork.
*
- * (Getting the lock is not really necessary, since we expect that this is
- * only used during single-process XLOG replay, but some subroutines such
- * as MarkBufferDirty will complain if we don't. And hopefully we'll get
- * hot standby support in the future, where there will be backends running
- * read-only queries during XLOG replay.)
- *
* The returned buffer is exclusively-locked.
*
* For historical reasons, instead of a ReadBufferMode argument, this only
--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2010-07-08 16:06:57 | Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and |
Previous Message | Andrew Dunstan | 2010-07-08 15:45:41 | Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and |