Re: Out of date comment in xlogutils.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joshua Tolley <eggyknap(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Out of date comment in xlogutils.c
Date: 2010-07-08 16:09:39
Message-ID: 26669.1278605379@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Joshua Tolley <eggyknap(at)gmail(dot)com> writes:
> I noticed the following out-of-date bits in a comment in xlogutils.c:

Removing the comment altogether doesn't seem appropriate. I changed it
to

* (Getting the buffer lock is not really necessary during single-process
* crash recovery, but some subroutines such as MarkBufferDirty will complain
* if we don't have the lock. In hot standby mode it's definitely necessary.)

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-07-08 16:20:17 Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and
Previous Message Magnus Hagander 2010-07-08 16:06:57 Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and