Re: Getting rid of "unknown error" in dblink and postgres_fdw

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Getting rid of "unknown error" in dblink and postgres_fdw
Date: 2016-12-22 17:54:32
Message-ID: 4bdf36c8-f325-3059-7421-b92cad2aa894@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/22/2016 06:55 AM, Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
>> On 12/21/2016 09:20 PM, Tom Lane wrote:
>>> I see that you need to pass the PGconn into dblink_res_error() now, but
>>> what's the point of the new "bool fail" parameter?
>
>> That part isn't new -- we added it sometime prior to 9.2:
>
> Oh! I misread the patch --- something about an unluckily-placed line
> wrap and not looking very closely :-(. Yeah, it's fine as is.
> Sorry for the noise.

Thanks -- committed/backpatched to 9.2

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2016-12-22 17:59:50 Re: An attempt to reduce WALWriteLock contention
Previous Message Robert Haas 2016-12-22 17:50:55 Re: [COMMITTERS] pgsql: Implement table partitioning.