Re: Exclude pg_internal.init from base backup

Hi,

On 02/09/17 21:08, David Steele wrote:
> Hackers,
>
> The cache in pg_internal.init was reused in days of yore but has been
> rebuilt on postmaster startup since v8.1. It appears there is no reason
> for this file to be backed up.
>

Makes sense.

> I also moved the RELCACHE_INIT_FILENAME constant to relcache.h to avoid
> duplicating the string.

+1

> +++ b/doc/src/sgml/protocol.sgml
> @@ -2384,6 +2384,11 @@ The commands accepted in walsender mode are:
> </listitem>
> <listitem>
> <para>
> + <filename>pg_internal.init</>
> + </para>
> + </listitem>
> + <listitem>
> + <para>

Not specific problem to this patch, but I wonder if it should be made
more clear that those files (there are couple above of what you added)
are skipped no matter which directory they reside in.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services