parallel dump/restore code on WIndows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Joachim Wieland <joe(at)mcknight(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: parallel dump/restore code on WIndows
Date: 2012-04-06 00:12:53
Message-ID: 4F7E3505.3030100@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Why was this code:

#ifdef WIN32
if (parallel_init_done && GetCurrentThreadId() != mainThreadId)
ExitThread(code);
#endif

removed from dumputils.c by commit
5e86c61a7eec0fdc6961493a150159fa8fc63b1c? The commit message doesn't
refer to it at all.

I don't understand it at all, and there is nothing in Joachim's latest
patch that would call ExitThread() from an exit handler, so the effect
seems likely to me to break parallel windows processing in nasty ways if
called from a worker thread, although I haven't tested it.

cheers

andrew

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2012-04-06 00:19:07 Re: Last gasp
Previous Message Thom Brown 2012-04-06 00:07:03 pg_receivexlog stops upon server restart