From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8(). |
Date: | 2012-01-05 22:55:55 |
Message-ID: | 4F062A7B.8090109@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 01/05/2012 05:30 PM, Alvaro Herrera wrote:
> Excerpts from Andrew Dunstan's message of jue ene 05 19:06:54 -0300 2012:
>> On 01/05/2012 12:05 PM, Andrew Dunstan wrote:
>>> Work around perl bug in SvPVutf8().
>>>
>>> Certain things like typeglobs or readonly things like $^V cause
>>> perl's SvPVutf8() to die nastily and crash the backend. To avoid
>>> that bug we make a copy of the object, which will subsequently be
>>> garbage collected.
>>>
>>> Back patched to 9.1 where we first started using SvPVutf8().
>>>
>>> Per -hackers discussion. Original problem reported by David Wheeler.
>>>
>> Ugh. This broke the regression tests. I'll get it fixed.
> Yeah, notice that it's causing crashes, not just different results.
Indeed. It looks like the garbage collection was a bit too eager, so I
have a fix where we control when it gets done.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2012-01-05 23:02:35 | pgsql: Fix breakage from earlier plperl fix. |
Previous Message | Alvaro Herrera | 2012-01-05 22:30:09 | Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8(). |
From | Date | Subject | |
---|---|---|---|
Next Message | Jeremy Harris | 2012-01-05 23:00:47 | Re: random_page_cost vs seq_page_cost |
Previous Message | Tom Lane | 2012-01-05 22:34:29 | Re: CLOG contention |