Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8().

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8().
Date: 2012-01-05 22:30:09
Message-ID: 1325802590-sup-3427@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


Excerpts from Andrew Dunstan's message of jue ene 05 19:06:54 -0300 2012:
>
> On 01/05/2012 12:05 PM, Andrew Dunstan wrote:
> > Work around perl bug in SvPVutf8().
> >
> > Certain things like typeglobs or readonly things like $^V cause
> > perl's SvPVutf8() to die nastily and crash the backend. To avoid
> > that bug we make a copy of the object, which will subsequently be
> > garbage collected.
> >
> > Back patched to 9.1 where we first started using SvPVutf8().
> >
> > Per -hackers discussion. Original problem reported by David Wheeler.
> >
>
> Ugh. This broke the regression tests. I'll get it fixed.

Yeah, notice that it's causing crashes, not just different results.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2012-01-05 22:55:55 Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8().
Previous Message Andrew Dunstan 2012-01-05 22:06:54 Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8().

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-01-05 22:34:29 Re: CLOG contention
Previous Message Tom Lane 2012-01-05 22:27:28 Re: Progress on fast path sorting, btree index creation time