| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_dump --exclude-table-data |
| Date: | 2011-12-14 14:31:45 |
| Message-ID: | 4EE8B351.5070100@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/14/2011 06:28 AM, Peter Geoghegan wrote:
> Not sure that I have a lot to add here, but I am officially listed as
> a reviewer, which is a responsibility that I don't want to shirk.
>
> In my opinion, this patch is obviously useful. I don't find the
> asymmetry that it will create with pg_restore to be troubling, so I'd
> favour committing it as-is.
>
> Extremely minor problem noted: There are two spaces at the start of
> one sentence in your SGML doc updates.
>
Thanks. Committed with that changed, although we seem to be getting
altogether too obsessive about white space, IMNSHO.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Cave-Ayland | 2011-12-14 14:44:24 | Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64 |
| Previous Message | Alvaro Herrera | 2011-12-14 14:05:24 | Re: Command Triggers |