Re: Avoid repeated PQfnumber() in pg_dump

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Subject: Re: Avoid repeated PQfnumber() in pg_dump
Date: 2021-07-22 23:39:33
Message-ID: 4EC9CB98-CA92-4401-9157-BECB296F94DE@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/15/21, 12:48 PM, "Daniel Gustafsson" <daniel(at)yesql(dot)se> wrote:
> While unlikely to be common, very wide tables aren’t unheard of. Either way, I
> think it has merit to pull out the PQfnumber before the loop even if it’s a
> wash performance wise for many users, as it’s a pattern used elsewhere in
> pg_dump.

+1

The patch looks good to me. I am marking it as ready-for-committer.

Nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-07-22 23:43:41 Re: Rename of triggers for partitioned tables
Previous Message Bossart, Nathan 2021-07-22 23:10:14 Re: Use WaitLatch for {pre, post}_auth_delay instead of pg_usleep