| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | houzj(dot)fnst(at)fujitsu(dot)com |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Subject: | Re: Avoid repeated PQfnumber() in pg_dump |
| Date: | 2021-07-15 19:46:36 |
| Message-ID: | 170AF83E-4A58-4AFF-A9C4-ED6896FD94F4@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 15 Jul 2021, at 04:51, houzj(dot)fnst(at)fujitsu(dot)com wrote:
> On July 15, 2021 5:35 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> Out of curiosity, how many columns are "many columns"?
>
> I tried dump 10 table definitions while each table has 1000 columns
> (maybe not real world case).
While unlikely to be common, very wide tables aren’t unheard of. Either way, I
think it has merit to pull out the PQfnumber before the loop even if it’s a
wash performance wise for many users, as it’s a pattern used elsewhere in
pg_dump.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2021-07-15 20:03:05 | data corruption hazard in reorderbuffer.c |
| Previous Message | Dean Rasheed | 2021-07-15 19:34:38 | Re: CREATE COLLATION - check for duplicate options and error out if found one |