Re: pgindent weirdness

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgindent weirdness
Date: 2011-04-20 21:05:51
Message-ID: 4DAF4AAF.9040709@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/20/2011 04:28 PM, Bruce Momjian wrote:
> So the list of possible additions Andrew supplied are cases where we
> never reference those typedefs --- seems like a cleanup opportunity.
>

I think the best cleanup idea is Aidan's, namely is we have declared
"typdef struct foo { ... } foo;" we should use "foo" in the code
instead of "struct foo". Then the typedef will be referenced, and the
code will be cleaner, and we won't run into the pgindent "struct" bug
either, so it's a win/win/win.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-04-20 21:12:58 Re: CLUSTER versus broken HOT chains
Previous Message Peter Eisentraut 2011-04-20 20:55:58 Re: Formatting Curmudgeons WAS: MMAP Buffers