| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Christopher Browne <cbbrowne(at)gmail(dot)com>, Greg Smith <greg(at)2ndquadrant(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Formatting Curmudgeons WAS: MMAP Buffers |
| Date: | 2011-04-17 14:27:20 |
| Message-ID: | 4DAAF8C8.5090001@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/17/2011 09:51 AM, Andrew Dunstan wrote:
>
>
> On 04/17/2011 04:26 AM, Andrew Dunstan wrote:
>>
>>
>> Now we could certainly make this quite a bit slicker. Apart from
>> anything else, we should change the indent source code tarball so it
>> unpacks into its own directory. Having it unpack into the current
>> directory is ugly and unfriendly. And we should get rid of the "make
>> clean" line in the install target of entab's makefile, which just
>> seems totally ill-conceived.
>>
>> It might also be worth setting it up so that instead of having to
>> pass a path to a typedefs file on the command line, we default to a
>> file sitting in, say, /usr/local/etc. Then you'd just be able to say
>> "pgindent my_file.c".
>>
>>
>
> OK, I have most of these bits.
>
> A new tarball of indent is available at
> <http://developer.postgresql.org/~andrew/indent.netbsd.patched.tgz>
> and if everyone agrees I'll push it out to the mirrors.
>
> Attached are two patches, one to remove some infelicity in the entab
> makefile, and the other to allow skipping specifying the typedefs file
> location either by setting it in an environment variable or by putting
> it in a hard coded location.
>
>
... and this one has a typo fixed.
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| pgindent.patch | text/x-patch | 932 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-04-17 15:48:56 | Re: MMAP Buffers |
| Previous Message | Andrew Dunstan | 2011-04-17 13:51:59 | Re: Formatting Curmudgeons WAS: MMAP Buffers |