Re: Formatting Curmudgeons WAS: MMAP Buffers

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Christopher Browne <cbbrowne(at)gmail(dot)com>, Greg Smith <greg(at)2ndquadrant(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Formatting Curmudgeons WAS: MMAP Buffers
Date: 2011-04-17 13:51:59
Message-ID: 4DAAF07F.4000005@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/17/2011 04:26 AM, Andrew Dunstan wrote:
>
>
> Now we could certainly make this quite a bit slicker. Apart from
> anything else, we should change the indent source code tarball so it
> unpacks into its own directory. Having it unpack into the current
> directory is ugly and unfriendly. And we should get rid of the "make
> clean" line in the install target of entab's makefile, which just
> seems totally ill-conceived.
>
> It might also be worth setting it up so that instead of having to pass
> a path to a typedefs file on the command line, we default to a file
> sitting in, say, /usr/local/etc. Then you'd just be able to say
> "pgindent my_file.c".
>
>

OK, I have most of these bits.

A new tarball of indent is available at
<http://developer.postgresql.org/~andrew/indent.netbsd.patched.tgz> and
if everyone agrees I'll push it out to the mirrors.

Attached are two patches, one to remove some infelicity in the entab
makefile, and the other to allow skipping specifying the typedefs file
location either by setting it in an environment variable or by putting
it in a hard coded location.

cheers

andrew

Attachment Content-Type Size
entab.patch text/x-patch 390 bytes
pgindent.patch text/x-patch 933 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2011-04-17 14:27:20 Re: Formatting Curmudgeons WAS: MMAP Buffers
Previous Message Peter Eisentraut 2011-04-17 09:17:00 blah blah set client_encoding segfault