Re: Add unistd.h to c.h

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: Add unistd.h to c.h
Date: 2011-03-11 16:54:18
Message-ID: 4D7A53BA.3000808@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11.03.2011 18:53, Bruce Momjian wrote:
> Heikki Linnakangas wrote:
>> On 11.03.2011 18:50, Bruce Momjian wrote:
>>> Twenty percent of our C files include unistd.h. Should we include
>>> unistd.h in c.h and remove mentions of unistd.h in files that include
>>> c.h?
>>
>> Why?
>
> Well, that is one less C include file in 151 C files, and just one
> additional line in c.h.

It would make 80% of C files include unistd.h unnecessarily, slowing
down compilation by some small margin.

-1

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-03-11 16:55:51 Re: Add unistd.h to c.h
Previous Message Robert Haas 2011-03-11 16:53:20 Re: Add unistd.h to c.h