Re: Add unistd.h to c.h

Heikki Linnakangas wrote:
> On 11.03.2011 18:53, Bruce Momjian wrote:
> > Heikki Linnakangas wrote:
> >> On 11.03.2011 18:50, Bruce Momjian wrote:
> >>> Twenty percent of our C files include unistd.h. Should we include
> >>> unistd.h in c.h and remove mentions of unistd.h in files that include
> >>> c.h?
> >>
> >> Why?
> >
> > Well, that is one less C include file in 151 C files, and just one
> > additional line in c.h.
>
> It would make 80% of C files include unistd.h unnecessarily, slowing
> down compilation by some small margin.
>
> -1

OK, I am just asking. FYI, we already include a boatload of includes in
c.h:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <stddef.h>
#include <stdarg.h>
#ifdef HAVE_STRINGS_H
#include <strings.h>
#endif
#ifdef HAVE_STDINT_H
#include <stdint.h>
#endif
#include <sys/types.h>

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +