| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Complier warnings on mingw gcc 4.5.0 |
| Date: | 2010-12-16 16:40:27 |
| Message-ID: | 4D0A40FB.1050905@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/15/2010 11:53 PM, Tom Lane wrote:
>
> OK, patch committed so we can get testing from the existing buildfarm
> members, but please try on your new installation too.
>
>
It's working, but I don't think it's right :-) In particular, I don't
believe this, or rather I don't believe that its converse is false:
/* If not HAVE_GETOPT, we are using src/port/getopt.c, which has
optreset */
The trouble is that while we've forced use of our getopt.c, we haven't
inhibited configure from checking the system's getopt. So on my test
system HAVE_GETOPT is defined. Possibly I was wrong about needing to
have optreset set with use of our port.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-12-16 16:58:24 | Re: [PATCH] V3: Idle in transaction cancellation |
| Previous Message | Tom Lane | 2010-12-16 16:24:11 | Re: default localtimestamp at time zone |