From: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> |
---|---|
To: | David Fetter <david(at)fetter(dot)org> |
Cc: | Greg Smith <greg(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Yeb Havinga <yebhavinga(at)gmail(dot)com>, Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
Subject: | Re: wCTE behaviour |
Date: | 2010-12-08 11:23:59 |
Message-ID: | 4CFF6ACF.1010605@cs.helsinki.fi |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2010-12-08 10:19 AM +0200, David Fetter wrote:
> On Sun, Dec 05, 2010 at 01:33:39PM -0500, Greg Smith wrote:
>> So this patch was marked "Ready for Committer", but a) no committer
>> has picked it up yet and b) Marko has made changes here that nobody
>> else has tested out yet that I've seen on the last. Accordingly,
>> that classification may have been optimistic. It seems to me that
>> another testing run-through from someone like David might be
>> appropriate to build some confidence this latest patch should be a
>> commit candidate. If there is a committer intending to work on this
>> as-is, they haven't identified themselves.
>
> I've tested this one and not managed to break it. One thing it could
> use is support for EXPLAIN ANALYZE.
What's wrong with EXPLAIN ANALYZE? Here's what I see:
=# explain analyze with t as (insert into foo values(0) returning *)
select * from t;
QUERY PLAN
--------------------------------------------------------------------------------------------------
CTE Scan on t (cost=0.01..0.03 rows=1 width=4) (actual
time=0.017..0.017 rows=1 loops=2)
CTE t
-> Insert (cost=0.00..0.01 rows=1 width=0) (actual
time=0.029..0.030 rows=1 loops=1)
-> Result (cost=0.00..0.01 rows=1 width=0) (actual
time=0.002..0.002 rows=1 loops=1)
Total runtime: 0.104 ms
(5 rows)
Regards,
Marko Tiikkaja
From | Date | Subject | |
---|---|---|---|
Next Message | Florian Pflug | 2010-12-08 13:02:36 | Re: pg_type.typname of array types. |
Previous Message | Dmitriy Igrishin | 2010-12-08 10:35:39 | pg_type.typname of array types. |