Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function

From: Mike Fowler <mike(at)mlfowler(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: David Fetter <david(at)fetter(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Round Robin Reviewers <pgsql-rrreviewers(at)postgresql(dot)org>
Subject: Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function
Date: 2010-08-06 08:04:15
Message-ID: 4C5BC1FF.4090604@mlfowler.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-rrreviewers

On 06/08/10 05:38, Peter Eisentraut wrote:
> On tis, 2010-07-27 at 16:33 -0700, David Fetter wrote:
>
>> * Do we already have it?
>>
>> Not really. There are kludges to accomplish these things, but
>> they're available mostly in the sense that a general-purpose
>> language allows you to write code to do anything a Turing machine
>> can do.
>>
> I think this has been obsoleted by the xmlexists patch

In many ways yes. The only surviving difference is that xpath_exists has
support for namespaces and xmlexists does not as the grammar expects
namespaces to be handled in the xquery. So if people expect namespace
support to be useful that having both functions is useful until I (or
someone who works faster than me) get xquery going.

If the patch is to be committed, does it make sense for me to refine it
such that it uses the new xpath internal function you extracted in the
xmlexists patch?

Regards,

--
Mike Fowler
Registered Linux user: 379787

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Boxuan Zhai 2010-08-06 08:23:58 Re: MERGE Specification
Previous Message Naveed Alam 2010-08-06 07:56:01 Re: Proposal / proof of concept: Triggers on VIEWs

Browse pgsql-rrreviewers by date

  From Date Subject
Next Message Kevin Grittner 2010-08-06 14:31:13 Re: CommitFest 2010-07 week three progress report
Previous Message Peter Eisentraut 2010-08-06 04:38:12 Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function