Re: [PATCH] Add sortsupport for range types and btree_gist

> On 25 Oct 2024, at 19:41, Bernd Helmle <mailings(at)oopsware(dot)de> wrote:
>
> So this is a new rebased version of the patches including regression
> tests with default (sortsupport) and buffering behavior. I split up the
> tests for buffering vs. non-buffering but kept them basically the same
> for testing the index builts.

Hi Bernde!
Thanks for the patch!

I have some notes.

First patch:
0. We have PG_FREE_IF_COPY(), does it suits your needs?
1. Tests do not check what actual build method is used. You can add INJECTION_POINT("gist-sort-build") and expect a notice there or something like that.
2. "Per default" -> "By default", "indexe" -> "index", "index quality" -> NULL (in 14 quality was bad, since 15 same "quality")

Second patch:
0. PG_FREE_IF_COPY in range_gist_cmp? :)
1. Some test of this new functionality?

Thanks!

Best regards, Andrey Borodin.