| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Joe Conway <mail(at)joeconway(dot)com> |
| Cc: | "Hackers (PostgreSQL)" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: libpq new connect function (PQconnectParams) |
| Date: | 2010-01-28 08:47:46 |
| Message-ID: | 4B614F32.7070704@lelarge.info |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le 28/01/2010 07:32, Joe Conway a écrit :
> On 01/26/2010 02:55 PM, Guillaume Lelarge wrote:
>> Le 26/01/2010 19:43, Joe Conway a écrit :
>>> On 01/25/2010 03:21 PM, Guillaume Lelarge wrote:
>>>> I didn't put any documentation before knowing which one will be choosen.
>>>> So we still need to work on the manual.
>>>
>>> Please send the documentation as a separate patch. Once I have that I
>>> will commit the posted patch, barring any objections in the meantime.
>>
>> You'll find it attached with this mail. Please read it carefully, my
>> written english is not that good.
>
> Final committed patch attached.
>
> One last code correction -- in psql/startup.c the original patch defines
> the keywords array in the body of the code, rather than at the top of
> the block.
>
> Minor improvements ( hopefully ;-)) to the documentation as well.
>
Thanks a lot.
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Takahiro Itagaki | 2010-01-28 08:59:11 | Re: Review: listagg aggregate |
| Previous Message | Pavel Stehule | 2010-01-28 08:40:01 | Re: Review: listagg aggregate |