Re: Patch: libpq new connect function (PQconnectParams)

From: Joe Conway <mail(at)joeconway(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: "Hackers (PostgreSQL)" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: libpq new connect function (PQconnectParams)
Date: 2010-01-28 06:32:30
Message-ID: 4B612F7E.90006@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/26/2010 02:55 PM, Guillaume Lelarge wrote:
> Le 26/01/2010 19:43, Joe Conway a écrit :
>> On 01/25/2010 03:21 PM, Guillaume Lelarge wrote:
>>> I didn't put any documentation before knowing which one will be choosen.
>>> So we still need to work on the manual.
>>
>> Please send the documentation as a separate patch. Once I have that I
>> will commit the posted patch, barring any objections in the meantime.
>
> You'll find it attached with this mail. Please read it carefully, my
> written english is not that good.

Final committed patch attached.

One last code correction -- in psql/startup.c the original patch defines
the keywords array in the body of the code, rather than at the top of
the block.

Minor improvements ( hopefully ;-)) to the documentation as well.

Joe

Attachment Content-Type Size
PQconnectParams-final.patch text/x-patch 27.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-01-28 07:31:54 Re: Streaming replication and wal skipping
Previous Message Greg Smith 2010-01-28 04:13:05 Re: CommitFest status summary 2010-01-27