| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Hot Standby and prepared transactions |
| Date: | 2009-12-16 07:10:58 |
| Message-ID: | 4B288802.5000804@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs wrote:
> Investigating how that could come about, it looks like there is some
> fairly strange stuff going on here. StandbyRecoverPreparedTransactions()
> is never called at all.
I told you so:
http://archives.postgresql.org/message-id/4B260B5E.3010401@enterprisedb.com
StandbyRecoverPreparedTransactions() is only needed to pick up the state
of prepared transactions when starting standby from a shutdown
checkpoint. At online checkpoints. they are included in the
running-xacts record like all other transactions.
> * Skip assert when doing SubTransSetParent in
> RecoverPreparedTransactions() when in Hot Standby mode because some
> subxids will have been marked already
Seems reasonable. Let's still Assert that the parent is the same as last
time.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kurt Harriman | 2009-12-16 07:29:33 | Re: Patch: Remove gcc dependency in definition of inline functions |
| Previous Message | KaiGai Kohei | 2009-12-16 07:04:09 | [PATCH] Remove obscure permission checks in FindConversion() |