Re: pgsql: Make directory name comparisons on Win32 case insensitive.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make directory name comparisons on Win32 case insensitive.
Date: 2009-04-04 07:55:55
Message-ID: 49D7128B.5070009@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> mha(at)postgresql(dot)org (Magnus Hagander) writes:
>> Log Message:
>> -----------
>> Make directory name comparisons on Win32 case insensitive.
>
> Hmm, for consistency you really should be doing
> pg_tolower((unsigned char) *foo)
> here.
>
> It's possible that the cast is not necessary on Windows, but
> even so code consistency is a good thing.

I see you've fixed this, thanks.

//Magnus

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message User Hinoue 2009-04-04 10:44:47 psqlodbc - psqlodbc: Improve the transactional control under
Previous Message Tom Lane 2009-04-04 04:54:08 pgsql: Rewrite interval_hash() so that the hashcodes are equal for