Re: pgsql: Make directory name comparisons on Win32 case insensitive.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make directory name comparisons on Win32 case insensitive.
Date: 2009-04-03 13:46:53
Message-ID: 27967.1238766413@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

mha(at)postgresql(dot)org (Magnus Hagander) writes:
> Log Message:
> -----------
> Make directory name comparisons on Win32 case insensitive.

Hmm, for consistency you really should be doing
pg_tolower((unsigned char) *foo)
here.

It's possible that the cast is not necessary on Windows, but
even so code consistency is a good thing.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message User Kpierno 2009-04-03 14:47:48 pglogparser - pglogparser: Added the Perl DBD SQLite module for
Previous Message Dave Page 2009-04-03 12:11:16 edb-debugger - server: Initialise plugin_info for all functions, not