Re: Re: [COMMITTERS] pgsql: Avoid MSVC breakage caused by my previous commit by not using a

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Avoid MSVC breakage caused by my previous commit by not using a
Date: 2009-03-08 19:14:44
Message-ID: 49B41924.6070308@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera wrote:
> Tom Lane wrote:
>> alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
>>> Avoid MSVC breakage caused by my previous commit by not using a variable in
>>> the src/bin/scripts Makefile.
>> Buildfarm says it's still broken.
>
> Hmm, yeah, apparently Mkvcbuild.pm needs to be updated with the list of
> files that need to be symlinked -- and it's not all that
> straightforward.
>
> I need some help here, as I have no way to test this.

This should be fixed per my commit a minute ago. Thanks for help over IM
to figure it out :-)

//Magnus

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-03-08 20:11:52 Re: pgsql: pg_bind_textdomain_codeset must exist only on ENABLE_NLS.
Previous Message Magnus Hagander 2009-03-08 19:13:38 pgsql: Fix MSVC build for new ways to pull in keywords.c and kwlookup.c.

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-03-08 19:28:50 compiler failures on buildfarm member wombat
Previous Message Josh Berkus 2009-03-08 19:09:42 Re: status of remaining patches