| From: | Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use. |
| Date: | 2009-01-22 09:00:00 |
| Message-ID: | 49783590.70506@tpf.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander wrote:
> Peter Eisentraut wrote:
>> Magnus Hagander wrote:
>>> However, one question: The comment currently says it's harmless to do
>>> this on non-windows platforms. Does this still hold true?
>> Yes, the non-WIN32 code path appears to be the same, still. But the
>> ifdef WIN32 part we don't want, because that presumes something about
>> the spelling of encoding names in the local iconv library.
>>
>>> If we do keep the thing win32 only, I think we should just wrap the
>>> whole thing in #ifdef WIN32 and no longer do the codeset stuff at all on
>>> Unix - that'll make for cleaner code.
>> Yes, that would be much better.
>
> Something like this then?
It seems OK to me.
regards,
Hiroshi Inoue
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2009-01-22 10:09:48 | pgsql: Explicitly bind gettext to the correct encoding on Windows. |
| Previous Message | Peter Eisentraut | 2009-01-21 15:54:41 | Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Parag Goyal | 2009-01-22 09:15:28 | Logging conflicted queries on deadlocks |
| Previous Message | Dimitri Fontaine | 2009-01-22 08:48:56 | Re: Pluggable Indexes (was Re: rmgr hooks (v2)) |