Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.
Date: 2009-01-21 13:34:30
Message-ID: 49772466.4090107@hagander.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut wrote:
> Magnus Hagander wrote:
>> However, one question: The comment currently says it's harmless to do
>> this on non-windows platforms. Does this still hold true?
>
> Yes, the non-WIN32 code path appears to be the same, still. But the
> ifdef WIN32 part we don't want, because that presumes something about
> the spelling of encoding names in the local iconv library.
>
>> If we do keep the thing win32 only, I think we should just wrap the
>> whole thing in #ifdef WIN32 and no longer do the codeset stuff at all on
>> Unix - that'll make for cleaner code.
>
> Yes, that would be much better.

Something like this then?

//Magnus

Attachment Content-Type Size
gettext_win32.patch text/x-diff 2.7 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message User Dim 2009-01-21 14:33:08 backports - min_update: New Directory
Previous Message Peter Eisentraut 2009-01-21 12:54:54 Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2009-01-21 14:01:53 Re: Pluggable Indexes (was Re: rmgr hooks (v2))
Previous Message KaiGai Kohei 2009-01-21 13:29:40 Re: Column-Level Privileges