Re: Autoconf, libpq and replacement function

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Autoconf, libpq and replacement function
Date: 2008-11-21 18:51:05
Message-ID: 49270319.70607@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Or in the same directly, called something else. Like fnmatchstub.h. See
>> attached, seems reasonable?
>
> Seems okay to me. Note: in future, don't bother posting configure
> diffs; nobody wants to look at that, just the changes in the autoconf
> input files.

Ok, will exclude it next time.

FYI, the if check in the configure (and configure.in) was backwards :-)
I posted the patch without testing it to get the "general idea" across.

Will run a set of test of the latest one on msvc as well, and then commit.

//magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jaime Casanova 2008-11-21 18:55:44 Re: HEAD build failure on win32 mingw
Previous Message Magnus Hagander 2008-11-21 18:50:01 Re: pg_settings.enumval as array