Re: Add const qualifiers to XLogRegister*() functions

On 28.08.24 12:04, Aleksander Alekseev wrote:
> Hi,
>
>> On 04.10.23 16:37, Peter Eisentraut wrote:
>>> On 03.10.23 13:28, Aleksander Alekseev wrote:
>>>> While examining the code for similar places I noticed that the
>>>> following functions can also be const'ified:
>>
>>>> - XLogRegisterData (?)
>>>
>>> I don't think this would work, at least without further work elsewhere,
>>> because the data is stored in XLogRecData, which has no const handling.
>>
>> I got around to fixing this. Here is a patch. It allows removing a few
>> unconstify() calls, which is nice.
>
> LGTM.

committed

> Note that this may affect third-party code. IMO this is not a big deal
> in this particular case.

I don't think this will impact any third-party code. Only maybe for the
better, by being able to remove some casts.

> Also by randomly checking one of the affected non-static functions I
> found a bunch of calls like this:
>
> XLogRegisterData((char *) msgs, ...)
>
> ... where the first argument is going to become (const char *). It
> looks like the compilers are OK with implicitly casting (char*) to a
> more restrictive (const char*) though.

Yes, that's ok.