Re: Proposed patch - psql wraps at window width

From: Bryce Nesbitt <bryce2(at)obviously(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Cc: heikki(at)enterprisedb(dot)com
Subject: Re: Proposed patch - psql wraps at window width
Date: 2008-04-18 04:14:58
Message-ID: 48082042.4070102@obviously.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<br>
Bruce Momjian wrote:<br>
<blockquote cite="mid:200804171407(dot)m3HE7EW24318(at)momjian(dot)us" type="cite">
<blockquote type="cite">
<pre wrap="">I also found that for hugely wide output it was better to give up (do
nothing), rather than mangle the output in a futile attempt to squash it
to the window width. So there is one more clause in the wrapping if.
</pre>
</blockquote>
<pre wrap=""><!---->
Was it because of performance? I have a way to fix that by decrementing
by more than one to shrink a column? I am attaching a new patch with my
improved loop. It remembers the previous maximum ratio.</pre>
</blockquote>
No!  Performance was not the issue.<br>
The out just looked like a jumble onscreen when the line was word
wrapped BUT did not fit on the screen anyway.<br>
<br>
To increase the number of layouts that fit, a co-worker suggested I
squeeze out the 2 spaces in each column header.<br>
<br>
                                          -Bryce<br>
<br>
</body>
</html>

Attachment Content-Type Size
unknown_filename text/html 1.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-04-18 04:19:05 Re: Lessons from commit fest
Previous Message Bryce Nesbitt 2008-04-18 04:11:12 Re: Proposed patch - psql wraps at window width

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-04-18 04:31:25 Re: Proposed patch - psql wraps at window width
Previous Message Bryce Nesbitt 2008-04-18 04:11:12 Re: Proposed patch - psql wraps at window width