Re: Proposed patch - psql wraps at window width

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bryce Nesbitt <bryce2(at)obviously(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, heikki(at)enterprisedb(dot)com
Subject: Re: Proposed patch - psql wraps at window width
Date: 2008-04-18 04:31:25
Message-ID: 21967.1208493085@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bryce Nesbitt <bryce2(at)obviously(dot)com> writes:
> <pre wrap="">I checked the use of COLUMNS and it seems bash updates the environment
> variable when a window is resized.

[ Please get rid of the HTML formatting ... ]

Bash can update the environment all it wants, but that will not affect
what is seen by a program that's already running. Personally I often
resize the window while psql is running, and I expect that to work.

I'm with Peter on this one: we have used ioctl, and nothing else, to
determine the vertical window dimension for many years now, to the tune
of approximately zero complaints. It's going to take one hell of a
strong argument to persuade me that determination of the horizontal
dimension should not work exactly the same way.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-04-18 04:42:06 Re: get rid of psql welcome message
Previous Message Bruce Momjian 2008-04-18 04:24:53 Re: Lessons from commit fest

Browse pgsql-patches by date

  From Date Subject
Next Message Martijn van Oosterhout 2008-04-18 06:34:49 Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout
Previous Message Bryce Nesbitt 2008-04-18 04:14:58 Re: Proposed patch - psql wraps at window width