Re: libpq Win32 Mutex performance patch

From: Andrew Chernow <ac(at)esilo(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: libpq Win32 Mutex performance patch
Date: 2008-04-11 21:52:23
Message-ID: 47FFDD97.4070009@esilo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Andrew Chernow wrote:
> Tom Lane wrote:
>> Silently not locking is surely
>> not very safe.
>>
>
> Here is the dump code version of the patch. If anyone wants the return
> value idea, let me know.
>
>
> ------------------------------------------------------------------------
>
>

A more graceful solution would be to print something to stderr and then
exit. This allows an app's atexit funcs to run. I don't think libpq
should core dump an app by choice. I'd be pretty upset if a library I
was using core dumped in some cases rather than exiting.

andrew

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-04-11 22:25:53 Re: libpq Win32 Mutex performance patch
Previous Message Bruce Momjian 2008-04-11 19:38:30 Re: Maintaining cluster order on insert