| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add CASEFOLD() function. |
| Date: | 2024-12-12 18:55:00 |
| Message-ID: | 47716a78-eb0b-4728-8991-fc0d958a01c9@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/12/24 13:30, Jeff Davis wrote:
> On Thu, 2024-12-12 at 21:52 +0900, Ian Lawrence Barwick wrote:
>> and it seems to work as advertised, except the function is named
>> "FOLDCASE()"
>> in the patch, so I'm wondering which is intended?
>
> Thank you for looking into this, I went back and forth on the name, and
> mistyped it a few times.
>
> ICU seems to use "foldcase":
>
> https://unicode-org.github.io/icu-docs/apidoc/dev/icu4c/ucasemap_8h.html
>
> and it seems to be slightly more proper grammatically (with "fold"
> being the verb). However, "case folding" is common terminology in
> Postgres and Unicode, so "casefold" can be seen as the verb instead.
>
> I don't have a strong opinion here so I will just go with whatever
> seems like the popular choice.
FWIW I prefer casefold()
--
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2024-12-12 19:19:01 | Re: [18] Unintentional behavior change in commit e9931bfb75 |
| Previous Message | Jeff Davis | 2024-12-12 18:30:04 | Re: Add CASEFOLD() function. |