Re: pgsql: Remove QueryOperand->istrue flag, it was used only in cover

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: Teodor Sigaev <teodor(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove QueryOperand->istrue flag, it was used only in cover
Date: 2007-09-12 07:56:41
Message-ID: 46E79BB9.2010100@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-patches

> Nice, I played around that myself as well today. I tried to use
> Bitmapsets, instead of bool arrays, but that turned out to be
> significantly slower than the way it used to be. It looks like that
> bool-array method isn't, so that's good.
Yeah, hope so.
>
> Increasing the length field in QueryOperand doesn't actually help,
> because TSVector still only uses 11-bits for the length. And there's
> checks in tsquery.c that forbid values longer than MAXSTRLEN=2^11-1 anyway.
I know, but I doubt that rename istrue field to unused is much better.

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message User Mkz 2007-09-12 07:59:54 pgbouncer - pgbouncer: fix check for authfile changes silly typo made
Previous Message User H-saito 2007-09-12 05:49:10 psqlodbc - psqlodbc: Duplication deletion.

Browse pgsql-patches by date

  From Date Subject
Next Message Pavan Deolasee 2007-09-12 08:07:18 Re: HOT documentation README
Previous Message Pavan Deolasee 2007-09-12 07:09:29 Re: HOT documentation README