| From: | "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> |
|---|---|
| To: | "Teodor Sigaev" <teodor(at)postgresql(dot)org> |
| Cc: | <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Remove QueryOperand->istrue flag, it was used only in cover |
| Date: | 2007-09-11 18:21:18 |
| Message-ID: | 46E6DC9E.2000500@enterprisedb.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-patches |
Teodor Sigaev wrote:
> Remove QueryOperand->istrue flag, it was used only in cover ranking
> (ts_rank_cd). Use palloc'ed array in ranking instead of flag.
Nice, I played around that myself as well today. I tried to use
Bitmapsets, instead of bool arrays, but that turned out to be
significantly slower than the way it used to be. It looks like that
bool-array method isn't, so that's good.
Increasing the length field in QueryOperand doesn't actually help,
because TSVector still only uses 11-bits for the length. And there's
checks in tsquery.c that forbid values longer than MAXSTRLEN=2^11-1 anyway.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-09-11 19:50:26 | pgsql: Give ICC its preferred, documented form of the no-strict-aliasing |
| Previous Message | Tom Lane | 2007-09-11 17:44:01 | pgsql: Sync timezone data with 2007g zic release. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-09-11 18:48:54 | Re: invalidly encoded strings |
| Previous Message | Tom Lane | 2007-09-11 18:06:09 | Re: prevent invalidly encoded input |