Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, mikael(dot)kjellstrom(at)gmail(dot)com, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?
Date: 2024-05-03 08:39:15
Message-ID: 46550BF9-9B04-4F3A-90FE-3780A32BF7FA@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 1 May 2024, at 06:21, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> My remark was originally about pq_init_crypto_lib that does the
> locking initialization, and your new patch a bit more, as of:
>
> ...
>
> So +1 to remove all this code after a closer lookup.

Thanks for review.

> I would
> recommend to update the documentation of PQinitSSL and PQinitOpenSSL
> to tell that these become useless and are deprecated.

They are no-ops when linking against v18, but writing an extension which
targets all supported versions of postgres along with their respective
supported OpenSSL versions make them still required, or am I missing something?

> ERR_clear_error();
> -
> #ifdef USE_RESOWNER_FOR_HMAC
>
> Some noise diff.

Will fix with a new rebase when once the tree has settled down from the
post-freeze fixups in this area.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-05-03 08:52:31 Re: Support LIKE with nondeterministic collations
Previous Message jian he 2024-05-03 08:14:27 Re: Document NULL