| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Mark Wong <markwkm(at)gmail(dot)com>, Michael Meskes <meskes(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ECPG failure on BF member Vaquita (Windows Vista) |
| Date: | 2007-04-25 19:56:58 |
| Message-ID: | 462FB28A.4060201@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
>
> Hmm, and I don't have to look far to find a smoking gun:
>
> #if defined(__GNUC__) && (defined (__powerpc__) || defined(__amd64__) || defined(__x86_64__))
> if (create_statement(lineno, compat, force_indicator, con, &stmt, query, args) == false)
> #else
> if (create_statement(lineno, compat, force_indicator, con, &stmt, query, &args) == false)
> #endif
>
>
>
I also see:
#if defined(__GNUC__) && (defined (__powerpc__) || defined(__amd64__) ||
defined(__x86_64__))
#define APREF ap
#else
#define APREF *ap
#endif
But I also see that my amd64/FC6 machine does pass these tests with gcc.
I would certainly be nice if we could simplify all this. And if not, we
should have a note about why it's needed.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-04-25 20:28:25 | My upcoming travel |
| Previous Message | Mark Wong | 2007-04-25 19:47:39 | Re: ECPG failure on BF member Vaquita (Windows Vista) |