| From: | ocean_li_996 <ocean_li_996(at)163(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | "Masahiko Sawada" <sawada(dot)mshk(at)gmail(dot)com>, "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re:RE: BUG #18055: logical decoding core on AllocateSnapshotBuilder() |
| Date: | 2023-08-20 16:51:30 |
| Message-ID: | 461dd3e6.197a.18a13dbdc8a.Coremail.ocean_li_996@163.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Excited! Thanks for the discussion and the fix!
The bug seems to be solved well. And usage of PG_FINALLY can make it more elegantly. However, for the version lacking of PG_FINALLY, should the patch be written like that:
---
/* free context, call shutdown callback */
FreeDecodingContext(ctx);
ReplicationSlotRelease();
InvalidateSystemCaches();
}
PG_CATCH();
{
+
+ /* free context, call shutdown callback */
+ if (ctx != NULL)
+ FreeDecodingContext(ctx);
+
+ ReplicationSlotRelease();
----
Best regards!
At 2023-08-18 12:21:53, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
Here is a new version patch which addressed this based on PG15.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2023-08-20 16:58:01 | Re: BUG #18061: The psql -v variable option does not work for the -c command option |
| Previous Message | Tom Lane | 2023-08-20 16:12:21 | Re: BUG #18060: Left joining rows using random() function in join condition doesn't work as expected. |