Re: Separate GUC for replication origins

On Thu, Mar 6, 2025, at 6:55 AM, Amit Kapila wrote:
> On Wed, Mar 5, 2025 at 4:38 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> >
> > On 11.02.25 21:25, Euler Taveira wrote:
> > > Here is another patch that only changes the GUC name to
> > > max_replication_origin_sessions.
> >
> > I think the naming and description of this is still confusing.
> >
> ...
> ...
> >
> > I agree that the originally proposed name max_replication_origins is not
> > good, because you can "create" (using pg_replication_origin_create())
> > more than the configured maximum. What is the term for what the setting
> > actually controls? How many are "active"? "In use"? Per session? etc.
> >
>
> It controls the number of active sessions using origin. The idea is
> that to track replication progress via replication_origin we need to
> do replorigin_session_setup(). If you look in the code, we have used
> the term replorigin_session* in many places, so we thought of naming
> this as max_replication_origin_sessions. But the other options could
> be max_active_replication_origins or max_replication_origins_in_use.

The word "session" is correlated to "replication origin" but requires some
knowledge to know the replication progress tracking design. The word "active"
can express the fact that it was setup and is currently in use. I vote for
max_active_replication_origins.

--
Euler Taveira
EDB https://www.enterprisedb.com/