Re: Buffer overflow in psql

From: "John D(dot) Burger" <john(at)mitre(dot)org>
To: pgsql-general(at)postgresql(dot)org
Subject: Re: Buffer overflow in psql
Date: 2006-11-27 15:24:08
Message-ID: 45E917CE-ABCD-46A8-9707-F1CBCEC6305C@mitre.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Tom Lane wrote:

>> Um, is that really considered a fix??? We all know that there's no
>> guarantee at all, even in ANSI C, that unsigned int isn't bigger than
>> 32 bits, right?
>
> OID is 32 bits. Full stop.

I should know better than to argue about this, but:

In that case, casting it as in the OP's code sample seems problematic
in the other direction:

sprintf(buf, "%u", (unsigned int)PQoidValue(results));

since unsigned int could be as small as 16 bits, thus truncating the
OID value.

Ok, I'll stop now, I promise.

- John D. Burger
MITRE

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Jeffrey Webster 2006-11-27 15:47:01 Re: PGDATA
Previous Message koppelp 2006-11-27 15:05:40 Re: kerberos authentication error with Windows 2003 SP1 AD