Re: tsearch in core patch, for inclusion

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Neil Conway <neilc(at)samurai(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: tsearch in core patch, for inclusion
Date: 2007-01-25 16:31:21
Message-ID: 45B8DB59.2090908@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Teodor Sigaev wrote:
>> the patch. I'm personally not sold on the need for modifications to the
>> SQL grammar, for example, as opposed to just using a set of SQL-callable
>> functions and some new system catalogs.
>
> SQL grammar isn't changed significantly - just add variants of
> CREATE/DROP/ALTER /COMMENTS commands. Next, functions haven't
> autocomplete feature or built-in quick help - if you don't remember
> exactly kind/type of argument(s) of function then you should read a docs.

I didn't read the patch but I did skim the docs for this and if the docs
are current I see things like this:

CREATE FULLTEXT DICTIONARY en_ispell
( OPT = 'DictFile="ispell/english.dict",
AffFile="ispell/english.aff",
StopFile="english.stop"'
) LIKE ispell_template;

ALTER FULLTEXT DICTIONARY en_stem SET OPT='english.stop';

Which to me is perfectly reasonable and intuitive. It is unfortunate
though that we still have the more odd grammar of actually using Tsearch
to query. Although I don't really have a better suggestion without
adding some ungodly obscure operator.

Sincerely,

Joshua D. Drake

--

=== The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
Providing the most comprehensive PostgreSQL solutions since 1997
http://www.commandprompt.com/

Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate
PostgreSQL Replication: http://www.commandprompt.com/products/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ray Stell 2007-01-25 16:33:29 Re: [HACKERS] how to plan for vacuum?
Previous Message Michael Meskes 2007-01-25 16:26:12 Re: ECPG buglet?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-01-25 16:33:50 Re: Getting rid of warnings
Previous Message Neil Conway 2007-01-25 16:28:06 Re: Getting rid of warnings