| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Getting rid of warnings |
| Date: | 2007-01-25 16:28:06 |
| Message-ID: | 1169742486.5447.29.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Thu, 2007-01-25 at 17:11 +0100, Magnus Hagander wrote:
> The header had:
> isort(int4 *a, const int len)
> and the code had
> isort(int4 *a, int len)
ISTM that the "const" keyword to an "int" function argument is
pointless, so the right fix is to remove the "const" from the
declaration in the header.
> Where does the ** part come in there? It's not even a pointer!
I believe Tom was just referencing that as an example of a
less-than-perfect compiler warning from VC++.
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2007-01-25 16:31:21 | Re: tsearch in core patch, for inclusion |
| Previous Message | Teodor Sigaev | 2007-01-25 16:15:15 | Re: tsearch in core patch, for inclusion |