Re: shared-memory based stats collector

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> Just FYI, Tom's started a thread which includes this over here-
> https://postgr.es/m/1850884.1599601164@sss.pgh.pa.us

Per that discussion, I'm about to go and commit the 0001 patch from
this thread, which will cause the cfbot to not be able to apply the
patchset anymore till you repost it without 0001. However, before
reposting, you might want to fix the compile errors the cfbot is
showing currently.

On the Windows side:

src/backend/postmaster/postmaster.c(6410): error C2065: 'pgStatSock' : undeclared identifier [C:\projects\postgresql\postgres.vcxproj]

On the Linux side:

1711pgstat.c: In function ‘pgstat_vacuum_stat’:
1712pgstat.c:1411:7: error: ‘key’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
1713 if (hash_search(oidtab, key, HASH_FIND, NULL) != NULL)
1714 ^
1715pgstat.c:1373:8: note: ‘key’ was declared here
1716 Oid *key;
1717 ^
1718pgstat.c:1411:7: error: ‘oidtab’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
1719 if (hash_search(oidtab, key, HASH_FIND, NULL) != NULL)
1720 ^
1721pgstat.c:1372:9: note: ‘oidtab’ was declared here
1722 HTAB *oidtab;
1723 ^
1724pgstat.c: In function ‘pgstat_reset_single_counter’:
1725pgstat.c:1625:6: error: ‘stattype’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
1726 env = get_stat_entry(stattype, MyDatabaseId, objoid, false, NULL, NULL);
1727 ^
1728pgstat.c:1601:14: note: ‘stattype’ was declared here
1729 PgStatTypes stattype;
1730 ^
1731cc1: all warnings being treated as errors

regards, tom lane