[Pljava-dev] Patch for SQLOutput implementation

From: thomas at tada(dot)se (Thomas Hallgren)
To:
Subject: [Pljava-dev] Patch for SQLOutput implementation
Date: 2006-09-22 20:56:11
Message-ID: 45144DEB.2050107@tada.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pljava-dev

Hi Markus,
I looked at it and it looks fine. If you want to do some more work on
it, then I'll wait until Monday applying it. Are you planning to look at
the C-code as well? You seem to know how to keep your bits in order :-)

Regards,
Thomas Hallgren

Markus Schaber wrote:
> Hi,
>
> Here's the patch attempt for the SQLOutput side.
>
> First, it seems that the writeBytes() method was broken, it did write
> nothing (not even the length count) for a zero-length array, which lead
> to random garbage being read or worse on readBytes().
>
> I also added some handle checks.
>
> As I also adopted your coding style wr/t {}s, so I included the input
> side again.
>
> I've to quit now, my schedule is tight his afternoon, but I'll see what
> I can do at the weekend and on Monday.
>
> Regards,
> Markus
>
>

In response to

Responses

Browse pljava-dev by date

  From Date Subject
Next Message Markus Schaber 2006-09-23 10:36:00 [Pljava-dev] Patch for SQLOutput implementation
Previous Message Markus Schaber 2006-09-22 16:10:37 [Pljava-dev] readBytes() / writeBytes()