| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Kris Jurka <books(at)ejurka(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: src/tools/pginclude considered harmful (was Re: [PATCHES] |
| Date: | 2006-07-14 19:29:20 |
| Message-ID: | 44B7F090.60906@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
>In combination with the amount of time wasted over the past two days,
>it is now perfectly clear that the existing pginclude tools are not
>NEARLY good enough to detect what they are breaking. I would like to
>propose that we revert all the include-related changes of the past two
>days, and that src/tools/pginclude be removed from the CVS tree, until
>such time as it is rewritten to be much smarter about what it is doing.
>
>
>
I agree with reverting. The tool looks pretty broken anyway, with
hardcoded paths and all sorts of stuff quite apart from logic problems.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2006-07-14 19:53:34 | Re: [HACKERS] putting CHECK_FOR_INTERRUPTS in qsort_comparetup() |
| Previous Message | Tom Lane | 2006-07-14 19:26:55 | Re: [HACKERS] putting CHECK_FOR_INTERRUPTS in qsort_comparetup() |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2006-07-14 19:53:34 | Re: [HACKERS] putting CHECK_FOR_INTERRUPTS in qsort_comparetup() |
| Previous Message | Tom Lane | 2006-07-14 19:26:55 | Re: [HACKERS] putting CHECK_FOR_INTERRUPTS in qsort_comparetup() |