Re: [HACKERS] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, "Charles Duffy" <charles(dot)duffy(at)gmail(dot)com>, "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()
Date: 2006-07-14 19:53:34
Message-ID: 200607142153.35116.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> > Doesn't look like it's allocating any nonlocal memory:
> >
> > http://sourceware.org/cgi-bin/cvsweb.cgi/libc/stdlib/qsort.c?rev=1.
> >12&content-type=text/x-cvsweb-markup&cvsroot=glibc
>
> But this file defines _quicksort() not qsort(). I was under the
> impression that the latter is actually a mergesort in glibc ...

The merge sort is here:

http://sourceware.org/cgi-bin/cvsweb.cgi/libc/stdlib/msort.c?rev=1.21&content-type=text/x-cvsweb-markup&cvsroot=glibc

It uses alloca, so we're good here.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-07-14 20:12:44 Re: [HACKERS] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()
Previous Message Andrew Dunstan 2006-07-14 19:29:20 Re: src/tools/pginclude considered harmful (was Re: [PATCHES]

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-07-14 20:12:44 Re: [HACKERS] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()
Previous Message Andrew Dunstan 2006-07-14 19:29:20 Re: src/tools/pginclude considered harmful (was Re: [PATCHES]